This message was deleted.
# general
s
This message was deleted.
e
This fix works https://github.com/linkedin/venice/pull/294 @Felix GV PTAL
f
Can you share what is the server error you saw? Any stacktrace or similar you could share?
e
I have updated the PR, sorry fo late reply
We could remove “Optional”, but I am not enough confident with the codebase to make such change
f
Hi Enrico, I checked a few things on my end and want to give you an update… 1. The
Store::getRmdVersionID
is indeed broken. It cannot work the way it is now… Thanks for flagging! 2. I’ve written a unit test on my end and I have not been able to repro exactly the same stacktrace as you, but fairly close… 3. I can confirm that using
Jdk8Module
would work in a clean slate situation, however, because we carry some broken
rmdVersionId
fields encoded in our ZK, we would break if we adopted the fix as is… I am not sure yet what is the path forward. I suspect we might need to rename the field as part of the fix, so that it does not clash with the old badly-encoded field name. But maybe there are other ways… We’ll get back to you on this ASAP. Thanks for your patience. And thanks again for flagging this bug!
e
Thanks
f
FYI, I think this PR will safely fix the issue: https://github.com/linkedin/venice/pull/295
e
I cannot test it today
I have left one comment