This message was deleted.
# generals
Slackbot
03/15/2023, 3:29 PMThis message was deleted.
👀 1
e
Enrico Olivelli
03/15/2023, 3:32 PMas a workaround I am making it configurable from an ENV variable
f
Felix GV
03/15/2023, 3:41 PMI think swapping
getHostName()getCanonicalHostName()e
Enrico Olivelli
03/15/2023, 3:42 PMI am testing it now, I will send out a PR soon
Enrico Olivelli
03/15/2023, 3:42 PMthanks
Enrico Olivelli
03/15/2023, 3:42 PMaren’t you afraid of consequences in Production ?
Enrico Olivelli
03/15/2023, 3:43 PMmy understanding is that this is kind of a breaking change
Enrico Olivelli
03/15/2023, 3:43 PMthe servers will start to advertise themselves with a different name
f
Felix GV
03/15/2023, 3:45 PMMight be more prudent to make it configurable, although it being in a static util is a hurdle for that 😞 …
Felix GV
03/15/2023, 3:45 PMWould be bigger refactoring to make it non-static / configurable
e
Enrico Olivelli
03/15/2023, 3:45 PMI know, let me play with it, and I will share my findings
f
Felix GV
03/15/2023, 3:46 PMAlthough that refactoring might be a good thing, since we’re doing something a bit wonky for tests (see
Utils::thisIsLocalhoste
Enrico Olivelli
03/15/2023, 3:46 PMI also have a couple of changes about the docker images in order to make them usable from k8s
Enrico Olivelli
03/15/2023, 3:46 PMI saw Utils::thisIsLocalhost 😱
f
Felix GV
03/15/2023, 3:46 PMThat’s super cool. Looking forward to seeing what it takes to run Venice in k8s 😄
Felix GV
03/15/2023, 3:46 PM@Ramez Debbas check this out ^