OK anyone got a good pair of eyes to
# package-development
w
OK anyone got a good pair of eyes to help tell me what I have done wrong and why the entityAction does not work from the content tree ? CC the whizkidds @Jacob Overgaard @Niels Lyngsø @melonesen @Kevin Jump https://cdn.discordapp.com/attachments/882984798719729704/1218163984491085904/What-Am-I-Doing-Wrong_encoded.mp4?ex=6606aa9e&is=65f4359e&hm=50cc3a6c17c3500bf386613bd0fae56f2af6076023704ebb5d1d6e04b17daed9&
j
No, seems like there is some kind of error going on. I had it working without awaiting the result at some point and then it failed after more changes. Might be some kind of race condition going on. Anyway, if you await the onSubmit() it seems to work
w
Yeh which is what Kevin said. Just seems pointless as I dont return any data
j
I agree
w
Ok good to know, im kinda starting to make sense of some of this 😛
n
@Kevin Jump @Warren Buckley Its actually not a bug.. Its sort of a feature, though I do understand its hard to see the relation immidiatly. So whats going on is that things are begin cleaned-up/destroyed when the action is done. Since you werent awaiting the modal, the action ended and that destroyed the modal, hence you dont get to see it. Its not only made so for the clean up, but there is a UX detail hidden in this. Your action menu should still be visible, while your inside modals of the action. Therefor the Action should stay 'alive' for the periode of its initiatives. I hope that makes sense 🙂
w
Not enough beer and or caffeine. So in the case I don't really need to wait on the submit as it never submits anything its just closes. Whats the best thing I should be doing ?
j
I think what Niels is saying is that you should await the onSubmit, because then the underlying system knows when to destroy the modal controller for you
2 Views