https://twill.io logo
Join Discord
Powered by
# 💪github-pull-requests
  • i
    Hi @domihagen thanks for that! I feel like the problem might have been how you extended it? Were you trying to implement a constructor on your extended handler?
  • d
    Hi @User, like it´s in the docs:
    Copy code
    use A17\Twill\Exceptions\Handler as ExceptionHandler;
    I also built the Custom-Handler 1:1 like the Twill one. => Same issue
  • d
    We have the default Handler.php from Laravel with just registration of Sentry.io
  • d
    Copy code
    public function register()
    {
        $this->reportable(function (Throwable $e): void {
            if ($this->shouldReport($e) && app()->bound('sentry')) {
                app('sentry')->captureException($e);
            }
        });
    }
  • d
    In normal usage it works well. Just the 
    package:discover
    and PHPStan makes problem
  • k
    Not sure where to discuss feature requests, so I'm just doing it here: I just got an email from spectrum that someone commented on my old feature request (didn't know you could even use spectrum anymore!). But it got me thinking: is the ability for a user to label or name blocks in the future plans for Twill by chance?
  • p
    Hey @User , just to make sure I understand, the idea is to let CMS users assign custom names to blocks, to find them more easily?
  • i
    Hey guys, we're definitely thinking about this. If you go to the start of #811986546503843850 there's a whole discussion about the block wrapper
  • i
    @pboivin one idea would be to put a truncated value of the first text field in the block, something that Craft does for example
  • i
    but it's difficult to fit a lot in there, so maybe giving the ability to name blocks would be better
  • p
    @ifox that's cool! I also think dynamic titles will help greatly (whatever the implementation ends up being)
  • k
    This is great news! Thanks :)
  • a
    Hi, I just sent a pull request adds Turkish language support for Twill.
  • a
    Hi @User i just fix auth:oauth-link-title and added "tr" to available_user_locales in twill.php config file in PR #1134
  • d
    @User I was thinking to do one for Romanian if my superiors will like twill and will require to support romanian, is it difficult to do it?
  • a
    No not at all, the Area17 team made things very easy for this. There is a lang.csv file in the vendor/area17/twill/lang folder, you just have to open it with any csv editor and fill in the Romanian section according to English. Then just put the file where you got it and run the "php artisan twill:lang" command.
  • d
    great thanks
  • a
    You're welcome
  • a
    Hi, i just sent an PR for creating and managing additional table actions.
  • r
  • r
    ups area7 instead of area17 I will be ban from the community ?
  • i
    the only right ways are A17 and AREA 17 so we're already off on GitHub ourselves
  • i
    we're going to get rid of that from Vue components in Twill 3.0 btw, it doesn't make sense to have to prefix custom components with a17-
  • h
    Since I have some more time now that I finished my freelance contract, I drafted this quick pr. I will check later to add some test (later this week). https://github.com/area17/twill/pull/1212
  • p
    This looks good @User , will do a quick review this afternoon (EST here)
  • h
    If you have some time, I want to chat about 
    \A17\Twill\Tests\Integration\CapsulesTest
    -> I think the $allFiles is not used, or I don't understand them. If I remove them all is still fine. -> I think the tests/stubs/capsules is not used, at least not by the CapsulesTest. -> It only seems to use the artisan command. But that is not desired for my test case as I do not want to add the service provider to capsules by default. What is your suggested approach to actually use the test/stubs/capsules/posts?
  • h
    Made it work, but I feel its too complicated.
  • p
    @User I did not work much with the capsules tests, I'll have a look today with your above comments in mind and I can report back. I've been working more and more with the test suite in the past 2 months or so and I agree that there is room for improvement in the workflow, especially when adding new integration tests.
  • n
  • d
    Update recommended laravel version https://github.com/area17/twill/pull/1758