https://trinitycore.org logo
Join Discord
Powered by
# 🏍・custom
  • n
    You say my problem is this one: https://discord.com/channels/376073286427344897/870722120458600528/1556959170799079486—so, a core bug; fair enough. But in that issue thread, you mention it’s already fixed in 
    master
    . Yet, I can't find any commit involving code changes to the 
    master
    branch during that period that actually fixes it. The friend who ported the event for me would like to fix the bug, but he doesn't want to have to look for a needle in a haystack. https://cdn.discordapp.com/attachments/870722120458600528/1557138903897473055/image.png?backend=b2&ex=6ac6b61c&is=6ac5649c&hm=284e3d9f47d33ae92ff025581e36d8c6cac54fc4b78c19f1aad2cfc90d37d064&
  • n
    You fixed that in the master branch on July 26, 2022 or it was fixed but there is no code commit to be found for it.
  • b
    > You fixed that in the master branch on July 26, 2022 this not true, it was fixed earlier, comment was made later when someone reminded me about it
  • b
    when exactly? i dont remember
  • n
    Okay, that makes the whole thing even more peculiar. Right now, I can only filter by date, and I don't even have any search criteria to see how you fixed it back then. But perhaps you know how to resolve it and what core changes are needed for example, "in file XY, search for Z and look at this specific function." As it stands, though, the search is practically impossible because it could be anything.
  • b
    well, not anything
  • b
    its gameobject and visibility
  • b
    and transport type 11
  • n
    We’ve managed to figure that much out, but the transport-related data is split across so many different files that narrowing it down has been impossible so far.
  • d
  • d
  • n
    My friend and I have been working on this for hours, searching and filtering specifically for July 2022. Thanks for the link; now my friend and I can analyze the code and potentially adapt it for version 3.35.
  • d
    You could also have checked all commits older than July with Shauren as author
  • n
  • d
    You can do that online with github
  • b
    thats... not actually a good recommendation, i make commits daily
  • d
    It's just tedious
  • d
    But it's better than "it's impossible"
  • d
    I've probably gone through tens of commit pages when I was searching for a specific commit 😛
  • d
    It's 700 lines added and 300 removed, that will take a while to port to 335. I'd recommend to create a branch and port small bits at a time
  • d
    Btw Shauren does that commit fix by accident SSC elevator killing you while jumping on it due to high Z diff ? As in the server can check if the player position serverside is the same as client side
  • d
    Or maybe it just makes it easier to fix
  • n
    I don't need to port every single file change—just the specific ones related to the transport.
  • b
    probably? never tested and dont know if its even a thing in 335
  • d
    Yeah 335 kills you
  • d
    You get fall damage
  • d
    But one couldn't simply trust whatever Z movement packets sent with go type 11 flags, as that would have allowed to just flyhack
  • d
  • d
    (I somehow still remember a debugging session from 12 years ago for whatever reason 🤷‍♂️ )
  • n
    Now I need to filter out which files I have to port, because the way I see it, I don't need to carry over all of them.