https://cloudposse.com logo
Join Slack
Powered by
Hello, could I please get a full review on these t...
# pr-reviews
i
Hello, could I please get a full review on these two @Igor Rodionov? These are the two new repos for 
CodeArtifact
that I was talking with Erik recently. • github.com/cloudposse/terraform-aws-codeartifact/pull/1 • github.com/cloudposse-terraform-components/aws-codeartifact/pull/3
i
@Andriy Knysh (Cloud Posse) can you approve this PRs ?
👀 1
for some reason my approves does not work
a
@Ivan Pinatti thanks for the PRs, please see the comment about the failing tests
👀 1
i
Fixed, could you please re-run?
a
approved and merged. but the release workflow failed github.com/cloudposse/terraform-aws-codeartifact/…/116754957733 @Igor Rodionov please check, it looks like an issue with the GH app token
@Ivan Pinatti after the release is fixed, it will be 
0.1.0
, so please update it in the other PR github.com/cloudposse-terraform-components/aws-codeartifact/pull/3/changes#…
i
Done @Andriy Knysh (Cloud Posse)
It seems it hasn't merged yet (and not released).. Is there anything I can help with @Andriy Knysh (Cloud Posse)?
a
after github.com/cloudposse/terraform-aws-codeartifact/pull/1 merged, it was not released. @Igor Rodionov the issue is with the GH app, please look into it and release 
0.1.0
i
i
Great! Thanks @Igor Rodionov. Do I have to do anything or you just have to approve/merge the github.com/cloudposse-terraform-components/aws-codeartifact/pull/3?
i
i
It seem it is red only because 
cloudposse/codeartifact/aws
is not on the Terraform Registry. The 
v0.1.0
GitHub release is fine, but registry.terraform.io returns Not Found, so lint and both terratest legs fail with "Module not found". Same for 
cloudposse/ipam/aws
, 
cloudposse/bedrock/aws
and 
cloudposse/agentcore/aws
, while 
ecr
and 
memorydb
resolve fine, so it looks like new module repos are not getting published to the registry. Could you publish 
terraform-aws-codeartifact
there @Igor Rodionov? That should turn the PR green with no code change.
i
@Ivan Pinatti checking
that weird
@Erik Osterman (Cloud Posse) It seem I need your help
we need to register on terraform registry and opentofu registry new modules
e
Ah, yes, I can help with that
CleanShot 2026-10-23 at 11.03.33 AM@2x.png
i
hm
e
Opentofu or hashicorp registry?
i
let’s start with hashicorp
cloudposse/terraform-aws-codeartifact
cloudposse/terraform-aws-ipam
e
ok, i signed out and back in; i think this will work
i
cloudposse/terraform-aws-bedrock
cloudposse/terraform-aws-agentcore
e
bedrock is not updated yet cc @PePe Amengual
same with agent core
it's just the example repo
i
ok
e
i can publish 
codeartifact
p
yes, funny enough I had to do all that Ipam stuff to be able to start working on this
e
@PePe Amengual is IPAM ready to publish?
p
yes,.I'm using already
is a breaking change for people that used it
migration guide was added
i
@Erik Osterman (Cloud Posse) can we do the same for opentofu?
e
I think open tofu updates automatically
i
@Ivan Pinatti then let’s wait a bit
👍 1
i
Let me know if there is anything I could help with. 🙂
i
@Erik Osterman (Cloud Posse) opentofu registry still missed the modules
could you help me to traige that
e
I'm taking a look
Ok, we need to submit a PR for that.
I'm checking what's missing.
i
@Erik Osterman (Cloud Posse) do we need to create some workflows that should register new modules for us?
Open in Slack
PreviousNext
Powered by