Hello, could I get a review please? - <https://git...
# pr-reviews
i
Hello, could I get a review please? • github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/123 - Adds
query_exclusions
so an archive can drop a class of logs, like health checks, without restating the whole query, and applies it to the
catchall
archive too.
šŸ‘€ 1
merged 1
a
@Ivan Pinatti thanks again for the PR. Can you please check what's going on with the failing test: github.com/cloudposse-terraform-components/aws-datadog-logs-archive/…/109979422446
šŸ‘€ 1
i
Looks like OpenTofu remote state problems, not related with the PR @Andriy Knysh (Cloud Posse).
Copy code
Error: module.iam_roles.module.account_map.data.terraform_remote_state.data_source[0]: Unable to read remote statee
The fixtures job writes state with Terraform and both variants download that same state artifact, so OpenTofu 1.13 rejects it as an unsupported state format, which pinning
tofu_version
or running fixtures per-variant would fix.
a
can you fix it in your PR? 9it started happening just now, we merged many PRs from you)
i
It has to be fixed in another repo, but let me see if I can submit a PR there. Give me a few mins.
The fixture fix is merged. Could you please kick the tests again @Andriy Knysh (Cloud Posse)?
šŸ‘€ 1
a
the PR is merged, thanks @Ivan Pinatti
i
Amazing! Thanks @Andriy Knysh (Cloud Posse)