Hey, could I please get a review on this one? - <...
# pr-reviews
i
Hey, could I please get a review on this one? • github.com/cloudposse/terraform-aws-waf/pull/134 - It adds captcha and challenge actions to byte-match and regex-match rules, two composite host-based rule types, and an OR scope-down for rate limiting.
merged 1
e
@Igor Rodionov can you look at the test failure
i
@Ivan Pinatti merged
gratitude thank you 1
i
@Igor Rodionov thanks! Could I please get a re-run on the Release job for this merge? github.com/cloudposse/terraform-aws-waf/…/36622545546 PR #134 merged yesterday but the release job failed pulling alpine from
public.ecr.aws
with a 429 rate limit, so no tag was cut. Everything else in the run passed.
i
@Ivan Pinatti done
i
Hey @Igor Rodionov, could I please ask you to resync
cloudposse/waf/aws
on the Terraform Registry?
v1.18.1
was released on GitHub at 16:12 UTC today and the tag is there, but the registry still lists 1.18.0 as newest. It is the only one of the module's 31 tags missing from the registry, and
v1.18.0
indexed within seconds of its release, so the publish webhook looks like it did not fire. It is blocking github.com/cloudposse-terraform-components/aws-waf/pull/85, which needs 1.18.1 resolvable. Thanks!
e
Are you using the opentofu registry?
(if so bear in mind it always lags)
i
It's the Terraform registry that is lagging, not OpenTofu, and it is failing the Terraform legs of CI on the PR I opened.
e
done, triggered a resync
gratitude thank you 1
i
Could any of you kick the CI / tests on this one please? It should work now. • github.com/cloudposse-terraform-components/aws-waf/pull/85
šŸ‘€ 1
It failed.... My other PR is having the same issue... I opened a possible fix PR, but not sure if you have other ideas/plans for this; github.com/cloudposse-terraform-components/.github/pull/186 cc: @Andriy Knysh (Cloud Posse)
The fixture is merged and it worked in another PR I had open, could you please kick the test again on this one? It should pass now. • github.com/cloudposse-terraform-components/aws-waf/pull/85
šŸ‘€ 1
merged 1