Heyy folks. I have another feature ready for feedb...
# atmos-dev
j
Heyy folks. I have another feature ready for feedback 👉 github.com/cloudposse/atmos/pull/3119 Keen on your thoughts!
a
we will review today
please address the 🐇 comments (resolve each one once addressed)
👀 1
j
Tamed the 🐰. Thanks for picking this up @Andriy Knysh (Cloud Posse) 🙇
Was about to fix the padding issue (precommit check), but I see the big tests just kicked off. Should I hold off from pushing? 😇 Figured it was allright, just pushed.
I see some of the tests failing, some that didn't before... bit flakey. Anything I can do?
a
we'll take a look after other PRs get merged
🙏 1
j
Rebased and resolved conflicts 🙏
👍 1
a
@Jorrit Elfferich one more comment regarding the falling Windows test, easy to fix
j
Taking care of it. Thanks Andriy for the patience here 🙌
👍 1
I see I just passed patch coverage. Want me to attempt adding some more there, @Andriy Knysh (Cloud Posse) ?
a
the coverage is good, I merged the PR, thank you for contributing
j
Nice, thanks @Andriy Knysh (Cloud Posse) 🙌 🙌 . Have another feature coming in 🔜 😄 .
🚀 1