Another PR, unrelated with the previous ones. Could I please also get a review? • github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119 ◦ Changes the archive bucket lifecycle default from

GLACIER

to

GLACIER_IR

. Datadog can't read

GLACIER

for rehydration or Archive Search, so on the default config the archive silently becomes unreadable a year after the first object lands.

@Ivan Pinatti I left a comment in your PR (thanks again for it). The test were failing for a not-related issue with the other components. We have updated the DD module and component, and released a new version with the fixes github.com/cloudposse-terraform-components/aws-datadog-integration/…/v2.0.0 please update the ref in your repo, and the tests should pass: github.com/cloudposse-terraform-components/aws-datadog-logs-archive/blob/…/vendor.yaml please ping me when done

Thanks @Andriy Knysh (Cloud Posse)! Updated the ref and pushed. Ready for another look whenever you have a moment.

@Ivan Pinatti sorry, one more comment, please address

It failed after the last fix @Andriy Knysh (Cloud Posse)

i see it, checking now (we will finish it anyway 🙂 )

Let me know if you need anything from me.

@Ivan Pinatti final attempt We have fixed the component and tests: • github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/121 • github.com/cloudposse-terraform-components/aws-datadog-logs-archive/…/v2.0.0 your PR github.com/cloudposse-terraform-components/aws-datadog-logs-archive/pull/119is rebased and merged

It has merged! Thank you @Andriy Knysh (Cloud Posse)

thank you for all the contributions