https://cloudposse.com logo
Join Slack
Powered by
<github.com/cloudposse/atmos/pull/3084> :rabbit2: ...
# atmos-dev
z
github.com/cloudposse/atmos/pull/3084 🐇 is ignoring me 😢
merged 1
( it posted right as I sent this of course )
kk, rabbit green. ptal 🙂
bump 🙏
a
🐇 approved so it must be good i'm reviewing now
z
Oh nice, I didn't know you could run coderabbit locally
After applying the fix, consider running 
coderabbit review --agent
for local
review. Visit https://docs.coderabbit.ai/cli.
a
@Zack left a comment in the PR (test are failing), please take a look
z
Going through it now a bit, using a new coding harness and not sure if I like it, thing goes off the rails
a
what harness are you testing?
z
oh-my-pi
not sure if I know how to use correctly but I'll ask it questions during a task and it'll just ignore me until its done
There's for sure some cool features but I dunno
a
@Zack something is wrong with the test in github.com/cloudposse/atmos/pull/3084 let us know if you need help to resolve it
👍 1
e
CleanShot 2026-09-09 at 11.21.08@2x.png
Please increase test coverage to 85%+
👍 1
a
@Zack 🐰 loves you 🙂 more comments, please address
z
yeah working on this, using my old harness 😭
Just doing another round of reviews myself real quick to make sure nothing weird is sneaking its way in
Alright, just finished and says we should be good. Ready for pipelines/you guys 🫡
Looking at why pipelines all red 🤨
a
what harness are you using now?
z
opencode
a
what model?
z
codex terra high
a
it can't understand what the issues are with the tests? or it's a harness problem?
z
It understands the problem now, just seeing some edge cases with the tests and behaviors of this new feature
👍 1
Like there was some DAG stuff in the tests that just kind of silently was incomplete
Trying to make sure I don't change any default behavior really, just want optionality here
e
The good news is tests fail much faster now 😃
z
yes 🎉 much appreciated
e
CleanShot 2026-09-09 at 16.21.32@2x.png
z
Tried to include (generate) some mermaid diagrams for logic. This turned out more complicated than I was expecting, trying not to introduce any breaking changes, although I doubt anyone else probably has a repo as stupid as ours where things would break 😅
e
You are definitely pushing it past what what we had imagined 😉 but that's good! makes it more robust.
z
But will iterate on why the testing is failing later
e
Throw Astra at it?
z
Org hesitating to enable it
e
Also, the .claude/skills/field-test is really good at uncovering issues
z
All I have is sol and sol isn't great either lol
e
while it's written for claude, you can use it with codex if you point it at it
z
Ill try that out
Ok field test is slick
a
@Zack you are close to finish github.com/cloudposse/atmos/pull/3084 please review the comments and mark them "Resolved" if you resolved them to make the 🐇 happy
z
Yeah going to run a few more rounds on it
Will ping here when ready for more pipelines
e
One more tip, I suggest using 
@coderabbitai review
instead of 
@coderabbitai full review
since 
review
will only look at the commits since the last review, while 
full review
looks at everything and there's always something it can nag about 😃
z
This PR needs to be perfect 😤
🤣 1
I did it 🥹
coderabbit will always only give me full reviews now 💀
ok - ready for pipelines again 🙏
🟡 1
Again pls
🟡 1
my 🤖 saying that this failure was a flake
can I get another rerun? job got cancelled somehow?
it passed
wheeeeeee
bump 🙏. Lmk if this implementation makes sense.
👀 1
e
Hey Zack, will likely take a closer look tomorrow or monday at the latest.
👍 1
@Andriy Knysh (Cloud Posse) can you take a look at this one?
👀 1
merged 1
🥳 1
3 Views
Open in Slack
PreviousNext
Powered by