may I get a review on <github.com/cloudposse/terra...
# pr-reviews
d
πŸ‘€ 1
merged 1
a
approved and merged
d
thanks @Andriy Knysh (Cloud Posse). Here’s the followup component version bump please, github.com/cloudposse-terraform-components/aws-waf/pull/83
πŸ‘€ 1
a
@david please updte the remote state modules to
2.0.0
github.com/cloudposse-terraform-components/aws-waf/blob/…/remote-state.tf
πŸ‘€ 1
d
bumped
πŸ‘€ 1
bumped the test module versions to hopefully fix terratest
πŸ‘ 1
a
almost all tests are ok now, except one:
Copy code
2026/08/18 19:26:58 ERRO TestRunSuite/TestBasic: deploy/atmos component/default-test/waf/basic β†’ failed
    suite.go:88:
        	Error Trace:	/home/runner/go/pkg/mod/github.com/cloudposse/test-helpers@v0.20.0/pkg/atmos/component-helper/suite.go:88
        	            				/home/runner/work/aws-waf/aws-waf/test/component_test.go:165
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1;
        	            	Error: Missing attribute separator
        	            	
        	            	  on <value for var.nested_statement_rules> line 1:
        	            	  (source code not available)
        	            	
        	            	Expected a newline or comma to mark the beginning of the next attribute.
        	            	exit status 1
        	            	}
πŸ‘€ 1
d
fixed and added a callout in the comment:
Worth noting for the shared test harness: any component input that needs to carry a
"
inside a string will hit this, so it may be worth escaping in
primitiveToHclString
(or switching to a generated
.tfvars.json
) rather than leaving each component to work around it.
πŸ‘€ 1
merged 1
a
merged, thank you @david
d
thanks!