DevOps Community Sponsored by Cloud Posse

SweetOps

Hey <@UB2EH889X>, hope you're doing well (not sure who to ping so I hope you can forward it to the right person :slightly_smiling_face:)

We are running into frequent Github rate limits with our drift detection as our project grows - the main culprit seems to be the pagination over the releases in the setup atmos action. I've submitted a PR to the setup action that hopefully remedies this (and speeds it up quite a bit as a result)

<https://github.com/cloudposse/github-action-setup-atmos/pull/116|github.com/cloudposse/github-action-setup-atmos/pull/116>

One tip:
<https://github.com/cloudposse-examples/atmos-pro-example-advanced/blob/main/.github/workflows/atmos-terraform-plan.yaml#L40-L41|github.com/cloudposse-examples/atmos-pro-example-advanced/blob/…/atmos-terraform-plan.yaml#…>

We don't use the action any more in our own workflows

That said, we should still make the optimizations you propose in the PR

Thanks for the tip; I looked into it before but I couldn't find any drift detection so I think that's why we didn't migrate to the new CI yet

While yes, in that workflow we are using native CI, the key takeaway is that all execution of atmos happens inside a container that already has atmos installed. Whether or not you use "native CI"

While I can't attest to that the drift detection action will run in the container, it I wouldn't rule it out.

So I suppose theoretically all the existing actions can be made compatible with the container by disabling the setup-atmos sub-action inside the actions?

(we arrived at this solution based on our own load testing with Atmos Pro; imagine a PR that modifies 500 component instances. It doesn't take more than a few commit pushes and replans to blow through all github rate limits).

Yes that's also partially why I ended up here haha

And address the coderabbit nitpicks
```Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/__tests__/setup-atmos.test.ts`:
- Around line 98-112: Move the githubReleaseArm fixture out of
setup-atmos.test.ts into the shared src/__fixtures__ location, export it from
the fixture module, and import it into the test suite where it is used. Preserve
the fixture's current values and structure.
- Around line 29-35: Replace the octokit method mocks in the affected tests with
nock interceptors for the tagged, latest, and paginated GitHub release API
requests used by createOctokit. Configure each response to match the expected
request and add afterEach(() =&gt; nock.cleanAll()) around these tests to remove
interceptors between cases.```

I looked into the reviews; I did not implement the nitpick about `nock` because it would affect other (unrelated to my PR) tests as well.

Kicked off the tests; if they pass we'll merge