https://cloudposse.com logo
Join Slack
Powered by
<@U09SP3D4536> <github.com/cloudposse/atmos/pull/2...
# atmos-dev
e
@Juan Aguero github.com/cloudposse/atmos/pull/2817 LGTM, I think we can iterate on this in a follow up PR
Should we merge this?
j
That works , wasn't sure whats next on it . Anything needed from me on that one? I do have the follow up one for 
rds connect
I can take out of draft but I had some questions on direction github.com/cloudposse/atmos/pull/2818
e
What's lef tis "On the "fewer args" direction" but we can do that in a follow up
I still think it's important, but it requires some more thought
j
sounds good im okay with that going out then. for rds connect its in pr description, left as draft due to these. Wasn't sure on approach but can def go diff direction or okay closing it out if it's better to hold off
open design questions (seeking direction)
1. Trusting the RDS cert— embedding a third-party CA bundle is net-new for Atmos. Embed (current), fetch-on-demand + cache, or require`--ca-bundle`?
2. Client dependency—`connect`shells out to the user's`psql`/`mysql`binary. Is a client-binary prerequisite acceptable for this kind of command?
e
fetch-on-demand + cache, or require`--ca-bundle`?
I think this. Note we do something with our caching proxy that is maybe related.
Client dependency—`connect`shells out to the user's`psql`/`mysql`binary. Is a client-binary prerequisite acceptable for this kind of command?
At a minimum, it should fail fast, to check that the required binary is installed before attempting auth. We have a helper function for that.
We can also auto install latest.
`psql`: it is already modeled in Aqua’s public registry, which Atmos consumes
Look at what we do elsewhere to support autoinstall if binary is not available.
e.g. hooks
mysql
unfortunately is only distributed with the server binary in a large archive. I would skip attempting auto install
j
Thank you ! I'll review further and get some changes pushed party parrot
e
Was swamped this week with PR reviews, so please ping me when you are ready for a review or awaiting feedback
Open in Slack
PreviousNext
Powered by