<@UB2EH889X> <github.com/cloudposse/atmos/pull/284...
# atmos-dev
s
@Erik Osterman (Cloud Posse) github.com/cloudposse/atmos/pull/2846 as a followup to github.com/cloudposse/atmos/pull/2667 this PRD covers HELM release lifecycle controls in Atmos it is tested against large helm codebase with jobs, hooks, dependencies, etc. implementation is also already there implemented as stacked PRs
e
This is great. I agree with the overall direction. Let me just noodle briefly on the parameters themselves. And the shape of the YAML
Left a comment
👀 1
s
agree on flux alike design, PRD updated
e
Approved PRD
🙌 1
Let me know what to review next
s
I'll ping you once stacked PRs will be updated
👍 1
@Erik Osterman (Cloud Posse) ready for review: github.com/cloudposse/atmos/pull/2849 one note: CI integration part is not tested yet, doing it now
e
I am concerned we are overloading the example for testing; generally we want examples to be "easy" happy-path demos, something anyone can grok
Instead, move complex tests/examples to tests/scenarios
...and restore the simple example for helm
s
ah, sorry, that was my testing scenarios that was leaked through integration testings rounds I guess 🙈
need to work on them
fixed 🙈
e
Also, can you dismiss any verified stale/fixed comments
s
Sorry, I'll get back to it soon, need to fix output of apply as it is now showing nothing