https://github.com/cloudposse/atmos/pull/2644 - This extends PR extend my previous above. I didn't include the change because I didn't want to do anything to delay the fix being merged. This new PR improves performance. It reduced the time it took to complete this

atmos secret list -s <stack>

against a real world stack of 72 components. With only the changes in PR 2642, it 34 seconds. While with changes in this new PR took only 21 seconds.

For context are you exclusively using SOPs?

Yes only SOPS. I am not using any other stores (yet) or secrets stores.

I think we do another optimization then; it shouldn't even need to decrypt the secrets

Yeah. The command I tested with doesn't unmask the secrets.

21 seconds is crazy slow still

I agree.

I will take a look. Let me know whatever other rough edges you find

One more piece of context, that may or may not matter. In the mentioned test of 72 components, only one had secrets defined. That's actually what surprised me the most. I didn't think it should take 30+ (or 20+) seconds list secrets when only one component had them defined. Plus the fact I wasn't unmasking the secrets.

Well it still has to check to see if it has a secret. I think the issue is that one of the things we do is to show an indicator whether or not that secret has been initialized.

Working as expected now. Same command completes in

0.46

seconds now.