https://cloudposse.com logo
Join Slack
Powered by
<fix(jit): honor metadata.component subpath for JI...
# atmos-dev
z
fix(jit): honor metadata.component subpath for JIT source-provisioned components by zack-is-cool · Pull Request #2371 · cloudposse/atmos Needs a conceptual look probably, basically found that the metadata.component doesn't do anything with JIT/workdir and this is a proposed fix to that so it works similar to normal vendored components
Tried to make it not a breaking change
But, it can be a breaking change if that makes sense, because with JIT/workdirs you really shouldn't need that metadata defined, unless you need to traverse the JIT'd module
TLDR it ignores it if it's not a real path, currently in this PR
e
But this should already be possible.
Did you use the subpath notation in the source URL?
z
yeah that's not the problem
You can JIT a subpath in the source URL. but, if that subpath references things like 
../../../
etc it blows up
because you don't have those directories
more context in the linked issue
e
aha, ok
😃
z
Yeah I know it's a stupid pattern
But... some of the modules we use 🫠
Ok, I've gotten the rabbits blessing. Lmk if anything needs to change @Erik Osterman (Cloud Posse)
e
@Andriy Knysh (Cloud Posse) can you take a look?
In a later PR we really need to move this stuff out of the exec pkg.
z
If you want me to get claude to also cover those usecases we can do that, I just personally have not used atmos with those other tools, and more specifically all of these features together
That's kind of where I've been finding bugs is when we try to use a bunch of features together, like hooks for ssm stores, jit, yaml templating for backends, all bells and whistles for newer features basically
Claude did call that out before that the other tooling will also face this issue but I don't know how relevant it would be to them.
e
I'll lean on @Andriy Knysh (Cloud Posse) for his thoughts on it
z
Yeah I mean whatever you guys think is best. That's the nice part about having claude do all the grunt work 😂
Refactoring isn't that painful
@Andriy Knysh (Cloud Posse) just wanted to follow up on this on the path forward?
a
i'll review this today. The outstanding issues are: 1) move the functions to 
pkg
; 2) Implement the same functionality for Packer/Helmfile/Ansible. How difficult for you + Ai would be to implement it?
z
Not difficult just wasn't clear on what you wanted me to do
Will work on this next week
a
thanks let me know if you need help
z
Alright, should be ready
👀 1
a
approved and merged, thanks @Zack
🙌 1
Open in Slack
PreviousNext
Powered by