https://cloudposse.com logo
Join Slack
Powered by
Any chance we could get another set of eyes on thi...
# atmos-dev
z
Any chance we could get another set of eyes on this bugfix https://github.com/cloudposse/atmos/pull/2184 ๐Ÿฅบ
Actually, I wonder if this is fixed by my changes.. let me play with this
a
let us know when it's ready for review
z
tried against build from main, no dice. It looks like this breaks against JIT/workdir components also In my case, it's trying to
Copy code
atmos list affected
๐Ÿงช affected is an experimental feature. Learn more <https://atmos.tools/experimental>
โœ— Fetching vpc_properties output from demo-vpc in mi-tst
โฃพ  Comparing
   Error 

            Error: template: templates-all-atmos-sections:434:52: executing "templates-all-atmos-sections" at <atmos.Component>: error calling Component: atmos.Component(demo-bastion, mi-tst) failed: failed to get terraform output for component demo-vpc in stack mi-tst, output vpc_properties: failed to retrieve terraform outputs: failed to generate backend file: open /Volumes/robot-garden/git-repos/DU/du-gitlab-repos/atmos/inf/.workdir/terraform/mi-tst-demo-vpc/backend.tf.json: no such file or directory
                                              
                                                ## Explanation

                                                                 failed to execute terraform output for component demo-vpc in stack mi-tst
Going to reach out to my co-worker for more context
I think this is broken currently, but idk if fixing it will actually work for our usecase most of the time
@Andriy Knysh (Cloud Posse) I don't think this is actually a blocker for us at this moment, but I do think that maybe 
describe/list
affected has some kind of bug in the logic where it doesn't know to JIT a required workdir to fetch a 
!terraform.state
function. It's similar error to if you were running atmos without doing a vendor pull first. It doesn't instantiate the workdir/init automatically. I'll add this to the issue
a
please do, we'll get to the issue soon
z
Was poking at this a little bit. I think it has something to do with worktrees. I still need to sus it out.
Been working on something for this PR that basically makes atmos smart enough to JIT a directory if someone is fetching outputs from it if it's relied on for another component
only effects JIT'd workdir operations, and respects the implemented TTL patterns
just running it through another cycle of compound-engineering to see if it's ready...
a
thanks, we'll review it
โค๏ธ 1
e
Kicked off the tests
โค๏ธ 1
z
Feel like some of this CI is blowing up because I'm running from a fork?
oh, maybe missing a label ๐Ÿ‘€
e
Yes, we can ignore the autofix failure.
Will look into that.
Copy code
Error                                                                        
                                                                                
   **Error:** not running in GitHub Actions or missing OIDC token environment   
   variables                                                                    
                                                                                
  ## Hints                                                                      
                                                                                
   ๐Ÿ’ก Set ATMOS_PRO_TOKEN for local/CI usage, or run in a GitHub Actions        
   workflow with id-token: write permission for OIDC authentication.            
                                                                                
   ๐Ÿ’ก See <https://atmos-pro.com/docs/configure/github-workflows> for setup       
   instructions.                                                                
DEBU Exiting with exit code code=1
a
this error is related to running on a fork and trying to upload to Atmos Pro
z
Right, probably missing some github organizational environment variables or secrets
a
(we should not try to upload to Atmos Pro when running on forks)
z
makes sense to me ๐Ÿ˜‚
Fixing up the tests now
Ok - claude is telling me this should be good now after re-generating the snapshots
a
z
@Erik Osterman (Cloud Posse) mind kicking tests off for this again?
a
i kicked it off
๐Ÿ‘€ 1
z
@Andriy Knysh (Cloud Posse) claude wants to make the test JIT module into a tarball, you guys ok with that?
Added more comments to the PR ๐Ÿค” but claude seems pretty confident this is a windows github runner issue
a
kicked it off again
z
Looks like it succeeded this time
๐Ÿ‘€ 1
a
we'll review it today/tomorrow we have a bunch of other PRs to review - all of that will be in the next Atmos release probably Monday
z
Cool, no rush
a
@Zack please resolve the conflicts in https://github.com/cloudposse/atmos/pull/2328, we'll review it now and merge
๐Ÿ‘ 1
z
ok should be good @Andriy Knysh (Cloud Posse)
๐Ÿ‘ 1
2 Views
Open in Slack
PreviousNext
Powered by