Could i get a review to close this small security ...
# atmos-devr
RB
03/28/2026, 3:38 AMCould i get a review to close this small security finding from github codeql?
fix: clear-text logging of sensitive information (CodeQL #5157) #2163
e
Erik Osterman (Cloud Posse)
03/31/2026, 3:45 AMLooks like there are some comments from Code Rabbit and @PePe Amengual
👀 1
Erik Osterman (Cloud Posse)
03/31/2026, 3:46 AMAnd the Windows tests are failing.
r
RB
04/01/2026, 4:18 PMI addressed the comments from Pepe and coderabbit. Now waiting for tests to pass.
p
PePe Amengual
04/01/2026, 4:23 PMHAHAHAH I was reviewing Atlantis PRs and somehow I clicked on this one and thinking I was in the atlantis repo I commented....
😂 1
PePe Amengual
04/01/2026, 4:23 PMmultitasking is not good
👍 1
e
Erik Osterman (Cloud Posse)
04/01/2026, 4:41 PMhaha hey, I thought it was pretty cool. 😃
Erik Osterman (Cloud Posse)
04/01/2026, 4:41 PMPlease feel free to chime in anytime.
🙌 1
👍🏽 1
r
RB
04/01/2026, 4:53 PM@Erik Osterman (Cloud Posse) mind re-reviewing the pr? tests pass now 🙂
RB
04/01/2026, 4:53 PM@PePe Amengual thanks for reviewing too!
e
Erik Osterman (Cloud Posse)
04/06/2026, 9:26 PM@RB looks like there's still some unresolved comments.
2 Views