https://cloudposse.com logo
Join Slack
Powered by
<prd> to track and decrease cyclomatic complexity ...
# atmos-dev
r
prd to track and decrease cyclomatic complexity in order to improve test coverage and thus reduce future bugs Related PRs ā€¢ https://github.com/cloudposse/atmos/pull/2226 ā€¢ https://github.com/cloudposse/atmos/pull/2225 ā€¢ https://github.com/cloudposse/atmos/pull/2204
āœ… 1
merged 1
a
@RB thanks. I'll get to it little bit later
šŸ‘ 1
e
CleanShot 2026-03-18 at 10.33.41@2x.png
I took a look at the first one, and noticed that the coverage is still below project level. Of course, it's probably much higher than it started off.
Are there any other opportunities or gains for increasing test coverage to 80%, which is our current goal?
2225 āœ… on coverage
r
Yes! Quite a few
e
2204 āœ… on coverage
r
By reducing these functions into smaller ones, we can unit test them to 100% and increase overall coverage to at least 80%
šŸ™ 1
e
so looks like 2226 is the only one
šŸ‘€ 1
Let's do that!
r
Should we start with the prd? I created prs for the highest functions with the largest impact
I thought maybe finding a way to stop the bleed might be beneficial too
e
I don't think we need the PRDs for the refactors.
šŸ‘ 1
but @Andriy Knysh (Cloud Posse) started a nice convention where docs/fixes are more or less the AI-generated plans of what was done and why.
šŸ‘ 1
This is helpful for understanding how regressions happen, or why they happen.
In retrospect.
Obviously all this hits at the core of Atmos, so we've got to be extremely careful that there are no regressions.
šŸ¤˜ 1
šŸš€ 1
a
i can point AI at all those fixes/files and it understands right away what was done before
šŸ™Œ 1
@RB we want to cut a patch release today with some fixes reported by users. Your changes will go into the next minor release
ā¤ļø 1
@RB I'll be able to review your PRs this week. Did you create a fix file in docs/fixes? Please let me know when everything is ready for review and testing (it's the Atmos core, we don't want to break things)
šŸ‘ 1
r
@Andriy Knysh (Cloud Posse) so i tried my best to iterate using coderabbit and copilot to find as many regressions as possible, improve test code coverage, and ensure tests pass. I'm pretty confident on 2225 and 2226. Please review those. 2204 is almost done. I was running another check yesterday and copilot had an outage. Just kicked off the rerun now
What's a fix file?
e
see 
docs/fixes/*
folder
šŸ‘€ 1
r
For fixes, should i use that docs/fixes path instead of the blog/roadmap entry or in addition to?
a
docs/fixes
is just to have 'memory' for people and especially for AI (in a new session, we can point it to a file to refresh its memory) just a practice that I'm using
šŸ‘ 1
blog/roadmap entry is for people to see what was done and changed
šŸ‘ 1
r
Ah interesting so the main difference seems to be the audience. Docs/fixes is for agents and blogs are for humans
āœ… 1
Thanks. I'll follow this convention for any fixes (non features)
this 1
a
Docs/fixes is for agents and blogs are for humans
Docs/fixes
is also for advanced humans (which we have fewer and fewer šŸ™‚ )
šŸ˜¬ 1
šŸ’Ŗ 1
šŸ˜Š 1
r
Thanks for working on those PRs and merging them!
I noticed the prd isnt merged yet its approved. Feel free to merge or close depending on if you think this initiative needs a prd or just docs/fixes additions or both
e
I think PR was in draft mode
2 Views
Open in Slack
PreviousNext
Powered by