A possible way to improve the stack deep merge by ...
# atmos-dev
r
A possible way to improve the stack deep merge by 3.5 times https://github.com/cloudposse/atmos/pull/2201/changes
👀 1
✅ 1
merged 1
e
@Andriy Knysh (Cloud Posse) would need to review this one
r
Friendly ping here. I iterated on this with coderabbit and copilot to improve these metrics
Copy code
| Score | Number | Grade | Delta vs previous |
|---|---|---|---|
| Merge Safety | 96/100 | A | 0 |
| Test Coverage | 78/100 | B- | +1 |
| Code Quality | 93/100 | A- | 0 |
| Security Posture | 92/100 | A- | 0 |
e
@Andriy Knysh (Cloud Posse) LGTM
👀 1
Just the usual trepidation changing core functionality. 😃
r
If you’d like to wait and do more tests, please feel free. I think I exhausted both copilot and coderabbit here lol but im sure there is room for improvement, given that the scores are not all 100 out of 100.
Thank you for considering.
e
@Andriy Knysh (Cloud Posse) has the most experience with this area of the code, so I will defer to his expertise
🙌 1
Long as you know, we can patch quickly if there’s any issues that’s all
💪 1
a
i’m going to review it, thanks for the contribution RB
🤘 1
@RB i improved your PR and merged to main. It will be in the next release. Thank you for the contribution, it should speed up atmos stack processing. I hope you don't mind me changing your PRs (I have added your name to all your PRs in the last release instead of the AI)
r
Of course, I do not mind at all. Thank you very much for considering the change and improving it 🙂