The datadog `monitors` submodule is not compatible...
# pr-reviews
s
The datadog
monitors
submodule is not compatible with the latest release of the DataDog Terraform provider. @johncblandii https://github.com/cloudposse/terraform-datadog-platform/pull/125
👀 1
merged 1
j
Someone on the team familiar with that one will need to review it
s
Ah sorry. Saw you were a codeowner/automatically added to the reviewers. @Erik Osterman (Cloud Posse) Would prefer for us not to have to switch our TF to use an internally published fork / pin to DD provider v3 here. Is there someone I can get this contribution in front of?
e
@Ben Smith (Cloud Posse) is best for this
Cc @Gabriela Campana (Cloud Posse)
✅ 1
b
LGTM - I marked it as a major release since we're upgrading a non-backward-compatible provider change. @Erik Osterman (Cloud Posse), we'll probably need to eventually split this module into individual repository modules, so that we can have individual provider management, as opposed to a major release for each subfolders update to the 4.x provider.
🙌 1
@Erik Osterman (Cloud Posse) @Ben Smith (Cloud Posse) Looks like one of the checks (test/terratest) stalled on last weeks commit. Considering @Ben Smith (Cloud Posse)’s comments about the other submodules, I bumped everything else up to v4 because they’re all technically compatible with v4 without any further changes. Would really like to get this out soon as it’s blocking a few workstreams on our end. We’ll probably have to switch to our fork soon if this can’t get merged in
e
@Sean Nguyen looks like we won't be able to get to it this week
I appreciate the contribution, but don't want to get in your way; suggest using your fork for now.
s
@Erik Osterman (Cloud Posse) How about this week? 🙂
b
Merged. With the major label tag, I think this is a fine update with the provider change. It was my one concern.
👍 1
e
Thanks Ben!
s
Much appreciated! Thanks a lot!
🙇‍♂️ 1