Expose the rest of elasticache redis inputs <htt...
# pr-reviews
r
merged 1
βœ… 1
m
Taking a look and running the tests now
πŸ™Œ 1
r
All passed 😁
i
Hey @RB, great PR! I believe yours closes this one; β€’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/62/ But not entirely sure that would close this one; β€’ https://github.com/cloudposse-terraform-components/aws-elasticache-redis/pull/63/
πŸ‘ 1
r
oof good call. it’s so annoying to set these in 2 diff places
you can also use some yaml magic to make it work via anchors for now
Copy code
anchors:
  default_redis: &default_redis
    num_replicas: 1
    num_shards: 0

terraform:
  components:
    elasticache-redis:
      vars:
        redis_clusters:
          redis-main:
            <<: *default_redis
            engine: "redis"
          redis-main-2:
            <<: *default_redis
            engine: "redis"
          redis-main-3:
            <<: *default_redis
            engine: "redis"
i
I do love YAML anchors and blundered on this... Perhaps it is indeed a more elegant solution.
I will cancel/close both PRs.
r
@Ivan Pinatti check if the recent changes in the component solved your above issue
πŸ‘€ 1
βœ… 1