fixed, there were 2 missing files that was not sta...
# atmos-dev
s
fixed, there were 2 missing files that was not staged. and fixed ini generation and file locking as well @Erik Osterman (Cloud Posse) @Andriy Knysh (Cloud Posse)
👀 1
e
Looks like some tests failed
s
checking, also added more test coverage
can you trigger 🐰 again
a
@shirkevich please execute
go test ./tests -v -timeout 10m
from the root of the repo and fix the failing tests
s
sorry, I've fixed acceptance tests, there was a regression after last refactoring. pushed
sorry, I need another commit to be merged which is fixing mandatory realm across cloud providers. Opening small PR now
please do not release new version out of it yet @Andriy Knysh (Cloud Posse)
👍 1
fixed 🐰 comments, and added docstrings, ready to go
a
@shirkevich sorry, one more comment 🙂 please address, and thank you for all the testing and improvements
s
aligned PR with https://github.com/cloudposse/atmos/pull/2075 to follow same opt-in realm isolation
👀 1
a
@shirkevich the PR is approved and merged, thanks a lot
🍌 1