This is ready for review <https://github.com/cloud...
# atmos-dev
p
merged 1
e
Please make sure the CodeRabbit review comments are addressed.
Please add a blog post announcing the enhancement.
p
I just did( most of them)
blog post?
e
Correct - so now all minor versions require a blog post as a changelog entry. You can just see what we did for the other changelogs. in the website/blog folder
p
ohhh website blog post ok
e
CLAUDE.md I believe has instructions.
👍🏽 1
p
done
e
❌ Patch coverage is
59.65909%
with
71 lines
in your changes missing coverage. Please review. ✅ Project coverage is 66.40%. Comparing base (
68bd160
) to head (
38fe527
). Can you please see if you can get it at least up to the project level of test coverage?
👍🏽 1
We're trying to get to 70% by the end of the year. We've been ensuring that no pull request regresses beneath the project coverage.
a
(show claude-code the above stats and ask to add more tests)
👍🏽 1
p
image.png
that is more than the S3 terraform.state coverage
e
Yep, that's fine. We don't need to hit 80%.
We just don't want to regress below the project's overall coverage because that's a regression that will cut test coverage.
Every PR raises the bar.
Thanks @PePe Amengual !
There's still the CodeRabbit review comments that look like they might not have been addressed. Use this with your AI agent.
Go through the various AI prompts that and address assess which ones are accurate.
p
but is the idea to address all comments? or the major ones?
e
It's to address all valid ones. And unless you can make a claim that it's invalid, then it should be addressed.
p
ok
e
😃
You're not being singled out.
p
no worries, not that I feel single out either
😃 1
ok, I went through a lot of comments
I think is ok now
this was passing test until I updated the PR from upstream, auth tests are failing
I fixed all rabit comments
e
I'm having the same problem with that snapshot there. I'm not sure yet what's wrong, but I'll get that fixed. Don't worry about that. Hold up. I'll see if I can get a PR in for that, and we'll let you know when we can merge this. We do want to merge your PR today or tomorrow.
👍🏽 1
a
@PePe Amengual thanks for the pr, it was updated and merged. Will be in the next release together with the fix for dependents in describe affected
fast parrot 1