Let us review these two prs in the same order as i...
# atmos-dev
s
Let us review these two prs in the same order as i mentioned bellow. note: I stacked the pr, just to avoid rework or waiting for the pr to get merged to main. So 3182 should be merged first then 3221 will automatically target main. Ofcourse review could be independent. Feature/dev 3182 add pager to atmos describe affected command by samtholiya · Pull Request #1255 · cloudposse/atmos Feature/dev 3221 add pager to atmos describe stack command by samtholiya · Pull Request #1265 · cloudposse/atmos add pager to describe workflow by samtholiya · Pull Request #1266 · cloudposse/atmos
e
Cc @Gabriela Campana (Cloud Posse)
s
Still in review
👍 1
e
@Ben Smith (Cloud Posse)
b
Hey @Shubham Tholiya I previously approved these, but it keeps getting dismissed as we update with main. Are these good to go? can I merge https://github.com/cloudposse/atmos/pull/1255?
🙏 1
s
Merged the branch... updating the stacked branch... it will be ready for review soon.
e
@Ben Smith (Cloud Posse)
b
Looks like #1265 is failing windows tests, tried re-running a couple times. I'll take a look later this week
e
checking @Dan Miller (Cloud Posse) and @Andriy Knysh (Cloud Posse) on this
I think this is smoething in main
s
retrying the test fixed it... but looks like a flaky one
b
https://github.com/cloudposse/atmos/pull/1293 I opened because it looks like the
describe workflows
command with pager wasn't working on my local
👀 1
s
added some comments
i will fix it... i realized we are talking about pager flag.
g
@Shubham Tholiya Patch coverage is
83.94161%
with
22 lines
in your changes missing coverage. Please review. http://github.com/cloudposse/atmos/pull/1276/checks?check_run_id=44433108817
e
Just to confirm Gaby that is a sufficient level of patch coverage
👍 1
It’s OK that some lines are missing tests
@Andriy Knysh (Cloud Posse) maybe you can review since Ben is slammed
👍 1
a
(we have a large PR that affects
describe affected
and changes a lot of files - let's merge it, than deal with the above PRs since there will be conflicts)
👀 1