Hi <@U02BF49S8UR> <@U0210GHDJQ0> Can someone of yo...
# atmos-dev
s
Hi @Dan Miller (Cloud Posse) @Ben Smith (Cloud Posse) Can someone of you check my pr's: Grew a lot because of the time it remained as a pr: https://github.com/cloudposse/atmos/pull/1174 Pager pr's: https://github.com/cloudposse/atmos/pull/1203 https://github.com/cloudposse/atmos/pull/1215 https://github.com/cloudposse/atmos/pull/1236 (after update test failed so fixing it now) no color pr's: https://github.com/cloudposse/atmos/pull/1227
e
I think @Ben Smith (Cloud Posse) was getting close to approving 1174
cc @Gabriela Campana (Cloud Posse)
b
Hey, i'll be reviewing these later today and approving if local tests work and merging if tests pass
sorry was going to do eaerlier but got caught up in something
s
Thanks @Ben Smith (Cloud Posse) No worries I understand 1174 is huge ๐Ÿ˜…
b
are any of the Pager PRs dependent on 1174. I think I remember seeing a todo in one of them
s
it is not dependent in that way. It is just a marker / backlog. Pager pr's are independent of that pr
๐Ÿ™Œ 1
b
Merged 1203 (Pager for config), looking at https://github.com/cloudposse/atmos/pull/1215 now which now has conflicts, looks like theyre mostly the same though not sure which is newer. would you rather me look at 1215 or 1236 first
s
Hey @Ben Smith (Cloud Posse) I am going to revert the
describe affected
pr 1236 merged into
describe component
#1215
Describe affected
was stacked on top of
describe component
because there were some improvements in
describe components
that i wanted to use and since the review was going to take time, I just stacked the pr so that
describe component
once merged to main I don't have to work a lot to change
describe affected
There are two reasons why i generally like merging these as two pr and not one, 1. describe component and describe affected are two seperate commands. If something goes wrong in one command it would be easier to revert only that command. 2. the pr has now grown due to
describe affected
and
describe component
๐Ÿ˜…
g
@Ben Smith (Cloud Posse) what is needed to get https://github.com/cloudposse/atmos/pull/1174 merged?
g
@Ben Smith (Cloud Posse)
๐Ÿ‘€ 2
b
ack, sorry saw a PR aiming at another PR so figured you wanted to combine them. This PR looks good, approved
s
g