It seems like I can't store complex types (like ma...
# atmos-dev
d
It seems like I can't store complex types (like maps) using the GSM Store. It raises
ErrValueMustBeString
while the other stores allow it by marshalling to/from json. I think I could implement this, but it'd be a breaking change 🤔
✅ 1
a
@Matt Calhoun
e
I believe we had this problem with SSM and recently fixed it
I thought we fixed the "Class of problem" but maybe not...
d
Marshalling is implemented at the store-level, so it was only fixed in SSM (GSM came later). We could avoid most breakage by falling back to treating the stored value as a string if it fails to parse, but there could still be cases where someone had expected a JSON-string value and are now receiving its parsed form
lmk when would be a reasonable timeline to get a review on this. would love to get us off of
!terraform.output
appreciate the quick release of my last pr!
e
@Dan Hansen I kicked off the tests. Can you review the lint warnings and comment if they are intentional, if so why.
@Dan Miller (Cloud Posse) @Ben Smith (Cloud Posse) can help review this tomorrow. It relates to @Matt Calhoun’s PR on https://github.com/cloudposse/atmos/pull/1116
🙌 1
d
a friendly bump on this 🙂
e
@Gabriela Campana (Cloud Posse)
d
@Dan Hansen looks good to me, sorry for the delay! approved now
d
thank you!
a
we merged it, thanks @Dan Hansen (will be released today)
❤️ 1
d
here's another one that is blocking our adoption of stores- https://github.com/cloudposse/atmos/pull/1260 I'm not sure where (or if I even can, how) to update the docs for this config
I tested this manually using a local build in addition to the unit tests. Are there any integration tests verifying parsing of the store yaml configs?
g
@Andriy Knysh (Cloud Posse)
a
thanks Dan, i’ll review in a few
❤️ 1
@Dan Hansen can you please address the AI comments
@Dan Hansen sorry to bother you again, but we'd appreciate if you addressed the comments in https://github.com/cloudposse/atmos/pull/1260 we are planning on a new release (prob tomorrow) and would like to include your PR as well
d
thank you! no worries about the ping. had some work incidents i was dealing with yesterday. I'll have the changes up in a few hours!
👍 1
pushed- coderabbit approved
👍 1