This is ready for review too <https://github.com/c...
# atmos-dev
p
This is ready for review too https://github.com/cloudposse/atmos/pull/963 The acceptance test are failing for some failing yamls I have not touched
e
Looks like they are passing now. Must have been a transient problem.
image.png
g
@Matt Calhoun
p
I fixed it after I posted the message
👍 1
a
@PePe Amengual thank you for the PR. Did you address all comments from all the AI and other bots? (please review them, if you address it, resolve it)
e
Yes, all code rabbit suggestions are addressed
Only one's left are codecov warnings, but test coverage is high enough to merge (50%)
a
@Matt Calhoun do you want to take a look at it? (since you commented on it before)
@PePe Amengual would you mind if I made a few changes in your PR?
p
not at all
a
@PePe Amengual I made a few changes in the PR, and added
Azure Key Vault
to the Store docs. Would you mind to finish the doc here
website/docs/core-concepts/projects/configuration/stores.mdx
Add
options
to the YAML config, and update the
Authentication
section (since you know all of these details) thank you
other than that, the PR looks very good
p
I was just thinking about the docs, I will do that
a
it's almost done, just please fill the missing parts
p
You can thank Cursor for the PR; it is 90% AI created
a
(hmm, i thought it was you 🙂 )
p
my prompts are
I think you take more time on the prompts than actually coding sometimes
a
(that's the future... the AI is saying now that the docs in the PR are not completed 🙂 )
p
LOL
mmm after some changes now I'm getting an error while testing in real life
Copy code
ERRO invalid YAML function function="!store dev/keyvault backend-apim" invalid number of parameters=2
ERRO invalid YAML function function="!store dev/keyvault backend-apim" invalid number of parameters=2
ERRO invalid YAML function function="!store dev/keyvault backend-apim" invalid number of parameters=2
is not making the stack optional anymore for some reason
checking
ok, I have a question about the implementation
so I'm testing it like this
Copy code
pepe: !store dev/keyvault sbox-wus3 backend-apim ""
dev/keyvault = point to the url of the kevault
sbox-wus3 = stack name
backend-apim = the name of a secret that is actually called
sbox-wus3-backend-apim
is the expectation that when you pass the component name to use the component name of the yaml only? or could we allow a user to grab a secret that is on a keyvault where the structure does not follow the atmos pattern?
the entire url for that secret is :
Copy code
https://sbox-wus3-pepe-kv.vault.azure.net/secrets/sbox-wus3-backend-apim
I'm wondering if my implementation is breaking any assumptions
a
@PePe Amengual the format is
Copy code
!store <store_name> <component> <key>
!store <store_name> <stack> <component> <key>
you have
!store dev/keyvault backend-apim
?
p
!store dev/keyvault backend-apim ""
I was thinking to be able to get secrets from keyvault but not related to a component
I guess I fail to understand how the values need to be injected to the Store
in the atmos format, I should have my secret in
https://sbox-wus3-pepe-kv.vault.azure.net/secrets/sbox-wus3-apimanagement/apimid
component =
apimanagement
key =
apimid