Shubham Tholiya
04/16/2025, 8:37 PMErik Osterman (Cloud Posse)
04/16/2025, 8:54 PMErik Osterman (Cloud Posse)
04/16/2025, 8:55 PMErik Osterman (Cloud Posse)
04/16/2025, 8:56 PMShubham Tholiya
04/18/2025, 4:28 PMShubham Tholiya
04/19/2025, 9:31 PMShubham Tholiya
04/19/2025, 9:34 PMErik Osterman (Cloud Posse)
04/19/2025, 9:35 PMErik Osterman (Cloud Posse)
04/19/2025, 9:35 PMErik Osterman (Cloud Posse)
04/19/2025, 9:35 PMShubham Tholiya
04/19/2025, 9:36 PMShubham Tholiya
04/19/2025, 9:36 PMErik Osterman (Cloud Posse)
04/19/2025, 9:36 PMErik Osterman (Cloud Posse)
04/19/2025, 9:37 PMErik Osterman (Cloud Posse)
04/19/2025, 9:37 PMShubham Tholiya
04/19/2025, 9:38 PMErik Osterman (Cloud Posse)
04/19/2025, 9:38 PMShubham Tholiya
04/19/2025, 9:38 PMErik Osterman (Cloud Posse)
04/19/2025, 9:38 PMShubham Tholiya
04/19/2025, 9:38 PMShubham Tholiya
04/19/2025, 9:38 PMShubham Tholiya
04/19/2025, 10:20 PMShubham Tholiya
04/20/2025, 4:01 PMShubham Tholiya
04/20/2025, 6:03 PMShubham Tholiya
04/21/2025, 8:27 PMErik Osterman (Cloud Posse)
04/21/2025, 9:04 PMShubham Tholiya
04/21/2025, 9:18 PMfalse
So in this case if i choose to keep the default
The issue would be our new pager would not be enabled by defaultShubham Tholiya
04/21/2025, 9:20 PMShubham Tholiya
04/21/2025, 9:20 PMErik Osterman (Cloud Posse)
04/21/2025, 9:49 PMErik Osterman (Cloud Posse)
04/21/2025, 9:49 PMtrue which is to use the native pagerErik Osterman (Cloud Posse)
04/21/2025, 9:49 PMfalse we disableErik Osterman (Cloud Posse)
04/21/2025, 9:51 PMErik Osterman (Cloud Posse)
04/21/2025, 9:53 PMErik Osterman (Cloud Posse)
04/21/2025, 9:53 PMsettings:
terminal:
pager: lessErik Osterman (Cloud Posse)
04/21/2025, 9:53 PMErik Osterman (Cloud Posse)
04/21/2025, 9:53 PMsettings:
terminal:
pager: !env PAGERErik Osterman (Cloud Posse)
04/21/2025, 9:53 PM!env at the conf levelErik Osterman (Cloud Posse)
04/21/2025, 9:55 PMErik Osterman (Cloud Posse)
04/21/2025, 9:55 PMless -FRXShubham Tholiya
04/22/2025, 7:07 PMsettings:
terminal:
pager: less
Does not evaluate to pager: true even if that is the default
My suggestion is we would require this for everything else. I can create a task for this in backlog. Meanwhile let us first continue adding this pager to every describe command starting with thisShubham Tholiya
04/22/2025, 7:09 PMErik Osterman (Cloud Posse)
04/22/2025, 7:19 PMMy suggestion is we would require this for everything else.Require what? not sure what "this" is here.
Erik Osterman (Cloud Posse)
04/22/2025, 7:20 PMDoes not evaluate to pager: trueNot enough information. Does not evaluate in this context means what? It errors? it's null? it's a string "true"
Erik Osterman (Cloud Posse)
04/22/2025, 7:23 PMpager be any?
Pager any `yaml:"pager"`Shubham Tholiya
04/22/2025, 7:23 PMDoes not evaluate in this context means what?
pager is true by default because we set the defaults in viper
Now if user is good enough he can set the value to be true or false and that will be catched by viper so we don't need to worry.
But the issue arrises when user is not entering the correct config
that is let us say he sets pager to less in config file or env (Flag is by default validated)
in this case the value of pager is set to false by viperShubham Tholiya
04/22/2025, 7:24 PMtrueErik Osterman (Cloud Posse)
04/22/2025, 7:24 PMErik Osterman (Cloud Posse)
04/22/2025, 7:24 PMShubham Tholiya
04/22/2025, 7:24 PMErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMShubham Tholiya
04/22/2025, 7:25 PMErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMsettings:
terminal:
pager: lessErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMShubham Tholiya
04/22/2025, 7:25 PMErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMErik Osterman (Cloud Posse)
04/22/2025, 7:25 PMless today based on the PAGER env (which could be less or more or anything)Erik Osterman (Cloud Posse)
04/22/2025, 7:26 PMPAGER is set by default on most systems. So if we just use boolean we'll basically never get to the native pager.Erik Osterman (Cloud Posse)
04/22/2025, 7:26 PMPAGER unless we run atmos like:
PAGER= atmos describe ...Erik Osterman (Cloud Posse)
04/22/2025, 7:26 PMunset PAGERShubham Tholiya
04/22/2025, 7:27 PMATMOS_PAGER ?Erik Osterman (Cloud Posse)
04/22/2025, 7:27 PMErik Osterman (Cloud Posse)
04/22/2025, 7:27 PMErik Osterman (Cloud Posse)
04/22/2025, 7:28 PMShubham Tholiya
04/22/2025, 7:28 PMShubham Tholiya
04/22/2025, 7:28 PMShubham Tholiya
04/22/2025, 7:28 PMShubham Tholiya
04/22/2025, 7:28 PMErik Osterman (Cloud Posse)
04/22/2025, 7:29 PMErik Osterman (Cloud Posse)
04/22/2025, 7:29 PMErik Osterman (Cloud Posse)
04/22/2025, 7:29 PMtrue is automatically considered a boolean and not a stringShubham Tholiya
04/22/2025, 7:30 PMShubham Tholiya
04/23/2025, 7:17 PMShubham Tholiya
04/23/2025, 7:30 PMdescribe component commandShubham Tholiya
04/25/2025, 8:47 PMShubham Tholiya
04/27/2025, 4:09 PM