Join Slack
Powered by
For pr: <Config Core library by samtholiya 路 Pull ...
# atmos-dev
s
Shubham Tholiya
04/12/2025, 3:41 PM
For pr:
Config Core library by samtholiya 路 Pull Request #1174 路 cloudposse/atmos
While my patch coverage percentage is 90.xx% Just because i removed some old code the coverage of utils.go dropped by 2.75% and codecov is complaining based on our thresholds. Can we ignore this?
a
Andriy Knysh (Cloud Posse)
04/12/2025, 5:06 PM
you can add a test for a command or a function - we have to do it anyway to get to 80% coverage
h
Haitham
04/13/2025, 3:18 PM
I added comments on you PR
馃憖 1
s
Shubham Tholiya
04/14/2025, 9:15 PM
@Haitham
Fixed some and commented on some
馃憖 1
Open in Slack
Previous
Next