For pr: <Config Core library by samtholiya 路 Pull ...
# atmos-dev
s
For pr: Config Core library by samtholiya 路 Pull Request #1174 路 cloudposse/atmos While my patch coverage percentage is 90.xx% Just because i removed some old code the coverage of utils.go dropped by 2.75% and codecov is complaining based on our thresholds. Can we ignore this?
a
you can add a test for a command or a function - we have to do it anyway to get to 80% coverage
h
I added comments on you PR
馃憖 1
s
@Haitham Fixed some and commented on some
馃憖 1