<@UB2EH889X> <@UB89GSWCF> please review <https://g...
# atmos-dev
h
@Erik Osterman (Cloud Posse) @Andriy Knysh (Cloud Posse) please review https://github.com/cloudposse/atmos/pull/1091
πŸ‘ 1
e
@Shubham Tholiya probably good to have you review this as well since it involves cobra
s
Sure
a
@Haitham
coderabbitai
made some comments that need to be addressed
h
all comments on PR resolved
s
Added one comment πŸ˜…
h
@Shubham Tholiya I added comment on it
@Erik Osterman (Cloud Posse) @Shubham Tholiya please I need you to review that
--config
is correctly implemented as a global flag while also being used in the
editorconfig validate
command. My PR includes changes in
validate_editorconfig.go
, so I need to verify that these changes don’t conflict with its existing logic for validate command
s
Cool will check this
h
@Shubham Tholiya I resolved your commit please review https://github.com/cloudposse/atmos/pull/1091#discussion_r2029405209
s
All good from my side πŸ™‚
βœ… 1