<@UB89GSWCF> hi, could you please take a look at t...
# atmos-dev
a
@Andriy Knysh (Cloud Posse) hi, could you please take a look at these ones when you have a minute? The merge order is important, has to be like this 1. PR 984 (globs), 2. PR 1149 (scp ssh) 3. PR 1076 (dry run)
s
Please take this on priority 1076 blocks my pr's for validate schema because after merging 1076 i have to manage some merge conflicts/updates on my pr: Refactor gogetter utility for better testability by samtholiya ยท Pull Request #1146 ยท cloudposse/atmos That would then eventually be used for atmos validate schema cc: @Erik Osterman (Cloud Posse)
โœ… 1
a
i'll review the 3 PRs now
๐Ÿ™ 1
e
Thanks
would love to close the book on these!
๐Ÿพ 1
sadly @Andrey Kalmykov more conflicts
๐Ÿ™ˆ 1
a
weโ€™ll release all three after the conflicts are resolved
a
@Andriy Knysh (Cloud Posse) thanks, have resolved the conflics, both are green now. Would appreciate if you could please take a look.
a
@Andrey Kalmykov the first two PRs are approved and merged, the last one has conflicts, please resolve
๐Ÿ™Œ 1
please let me know here when the conflicts are fixed and the PR is ready for review
a
@Andriy Knysh (Cloud Posse) hi, wrt to 1076 - could you please hold on for tonight as I need to run couple more tests, will get back with an update tomorrow
๐Ÿ‘ 1
@Andriy Knysh (Cloud Posse) hi, as agreed, have added more test cases, I guess 1076 is ready to be merged. All green now. Once it is merged, I guess it will be safe to release (up to you though) the code for all the 3 PRs in scope (globs + scp ssh + vendoring dry run).
โœ… 1
merged 1