<@U07RLUFFH7W> <@U084473LJNA> both of you are modi...
# atmos-dev
e
@Haitham @Shubham Tholiya both of you are modifying atmos config handling. https://github.com/cloudposse/atmos/pull/1123 https://github.com/cloudposse/atmos/pull/1074 I don't know what the right way to handle it, whose should win. But I am inclined to say @Haitham since it has the most tests, and is the direction we want to move with Viper .
But @Shubham Tholiya's PR is currently passing tests
And @Haitham’s is failing 😃
h
This not my final pr I fixed all test on next PR
This PR pass all tests
@Erik Osterman (Cloud Posse) pr 1085 includ changes which on pr 1074
s
1123 will be useful for the schema validation feature that we want in Atmos. And considering i have chained pr's of it, the feature could be delayed.
šŸ‘ 1