<@UBED6CS1Z> I would like to know if my understand...
# atmos-dev
s
@Igor Rodionov I would like to know if my understanding is correct. Fix go releaser configs to support pre-releases by goruha · Pull Request #1117 · cloudposse/atmos Was this fix done so that the pre-release tag works correctly? The reason i am asking is that would explain: https://sweetops.slack.com/archives/C031919U8A0/p1741647900276529
i
it depends of what you define as “correct”.
now we would not have 2 pre-release releases points to the same commit
s
For me correct is: pre-release = true for all Release Candidate and pre-release = false for all Release
i
but we still could have pre-release and release point to the same commit
@Shubham Tholiya that’s true, and it was always true
do you know any release with wrong flag value?
s
No i was just asking because i tried to check the function
GetLatestGitHubRepoRelease
we used in version
1.163.0
(customer's version that had issue) By using a my own repo to try to reproduce the issue. But i failed.
Currently we have a new version of
GetLatestGitHubRepoRelease
and even in that version the issue was not reproducable
i
I belive that because
1.166.0-rc.2
is not latest any more
now the latest release point to commit that have 1 release (regular one)
the latest
pre-release
points to commit that have no
regular release
s
This is how i am trying to reproduce the issue: I created similar scenario we had here; Releases · samtholiya/deep-learning-examples And then just passed my repo param to the function
i
if we will have once again the case when there is 2 releases to the latest commit the issue would appears agaoin
right
is the version we have at customer atmos show rc releases for your case?
s
nope
i
weird
create new rc point the same commit
v2.0-rc-1
s
okay checking
ahh interesting Old algo: Failed and i was able to reproduce. And now i know the reason as well New version Works perfectly cc: @Erik Osterman (Cloud Posse)
Thanks @Igor Rodionov 😅
But this means we already fixed the issue 🙂
e
Ok, what did we change that fixed in @Shubham Tholiya?
s
We now use latest release api instead of the old list releases api. As already shared. Latest Release does not return Pre-release versions. in the old version that the customer was using we were using List Release api that returns all the versions. I tried locally to reproduce the issue and found out that new update is working fine, while the old version failed (Just like the customer reported).
e
aha!
Yes, that would of course fix it.