Let's consider using more `severity: warning` rath...
# atmos-dev
e
Let's consider using more
severity: warning
rather than changing the limits of lint rules. The lint rules are the target, and once the code quality improves we can increase severity, rather than lowering the bar now.
✅ 1
Still having trouble
@Haitham @Vinny @Andrey Kalmykov
I probably can't focus on this more today
But if any of you can play with these settings in your branches and get the linting errors downgraded to warnings, that's what i would prefer we do rather than keep lowering the bar
h
@Erik Osterman (Cloud Posse) I can try to mange linting errors downgraded to warnings
👍 1
v
I guess this is not implemented yet, as open discussion in golanci. For us would be perfect if we have a feature like some linters failing while others just warning so we can start the bar raising while moving ahead
e
as open discussion in golanci.
do you have a link?
v
this seems to be the same thing @Erik Osterman (Cloud Posse) https://github.com/golangci/golangci-lint/issues/1981
yes they have it documented but still return exitCode as 1
a
Guys, having the same issue, if I up the numbers instead of putting severity:warning, it still fails. Any best practice you can suggest to address this? Or we just keep upping the numbers? I faced this issue with vendoring downloadAndInstall function where I had updated only one log message and it started to fail with complexity/nestedifs etc. Those parts are out of scope of my PR, so tried to up the respective numbers in the linter config file, but seems this warning approach doesn’t yet work. Any suggestions are welcome.
e
I am still looking into it.
Gave up on review dog
But still have issues trying to limit it to affected lines
Looking into a workaround.
Ok! I got this working very nicely. in #1137 1. I ripped out reviewdog and rolled out the native github action for golangci-lint. 2. I enabled sarif output format and upload those findings to CodeQL 3. Developers can dismiss results with a comment. Once all are resolved or dismissed, CodeQL is happy.
🙌 1
image.png
image.png
We've merged this PR and updated most branches
Please review your lint errors, and I think we're one step closer to merging the PRs
🙌 1