<@UB89GSWCF> hi, have fixed the issue with semicol...
# atmos-dev
a
@Andriy Knysh (Cloud Posse) hi, have fixed the issue with semicolon before the repo name, please kindly take a look if it is better now https://github.com/cloudposse/atmos/pull/984
❌ 1
e
a
@Erik Osterman (Cloud Posse) thanks, so I though that we want some backward compatibility and Miguel said that his url (obviously not correct in terms of the regex proposed) used to work, so we should probably tell him that at some point. Wrt to your comment, thanks, makes sense, will spit the ssh and http cases expliticlty. Let me prepare the updated function, will push and ping you here.
e
I think the fix is just to remove what you've done
It appears the proper fix is this: https://github.com/cloudposse/atmos/pull/1054
Can you validate 1054?
πŸ‘€ 1
It might mean a combination of the 2 fixes
one, to support scp-style URLs
two, to enable SSH vendoring
e.g.
Copy code
git@example.com:foo/bar.git β†’ git::ssh://git@example.com/foo/bar.git
git::ssh://git@example.com:foo/bar.git β†’ git::ssh://git@example.com/foo/bar.git
ssh://git@example.com:foo/bar.git β†’ git::ssh://git@example.com/foo/bar.git
Bear in mind, in URLs, the most common usage of
:
after
://
is for the port.
πŸ‘ 1
And it makes absolutely no sense to handle the
:
after
https://
or
http://
URLs as a non-port or for SSH urls
Let’s not do this in this PR
Let’s revert the fix, get this ready to merge
Then look at the SSH fix in a new Pr
a
@Erik Osterman (Cloud Posse) hi, thanks, apologies for the delay, have just tested both scp style URLs and SSH, seems to work fine, also added a check if an SSH agent is running, and if not, will through a error. Have moved the new code into a standalone PR as requested. Would appreciate if you could take a look please. The old code with the reverted changes is here ready to be merged. Wrt to 1054 validation - the proposal is good, it works, have checked with
source: "git::ssh://git@bitbucket.org/listener430/coonector.git//demo-vendoring?ref=main"
So I think we should merge 1054. Wrt to Miguel comments - the url he provided will work assuming the new PR with SSH and SCP added is merged.