<@UB89GSWCF> this is ready for final review <http...
# atmos-dev
e
@Andriy Knysh (Cloud Posse) this is ready for final review https://github.com/cloudposse/atmos/pull/870
merged 1
a
@Haitham LGTM in general, please address the comments
✅ 1
h
@Andriy Knysh (Cloud Posse) I will do
a
note that the command
atmos terraform clean
to clean all components in all stacks is one of the most requested feature. please fix it and test
atmos terraform clean --force
seems to be working, but I did not test it in all scenarios, please test it as well
✅ 1
s
Let us add test cases. To test all the scenarios. This command being critical we should also have a e2e test so that no one breaks it
a
please do
as I mentioned, many people wanted it (to be able to clean all components in all stacks)
e
@Haitham added a lot of tests in this PR
s
awesome... Sounds good.
h
@Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse) I think I covered the required test for clean if there is more test required please mention it on PR
👍 1
@Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse) for https://github.com/cloudposse/atmos/pull/870 I added test I fixed bug for atmos clean vaild terraform clean command - atmos terraform clean - atmos terraform clean
component
- atmos terraform clean` component` -s
stack
👀 1