This is ready for final review <@UB89GSWCF> <https...
# atmos-dev
e
This is ready for final review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/941
@Vinny since you are testing the version command for log output, and enabled snapshots, we will need to also update the diff. There are other tests that are testing the version, and you can copy the diff expression from them.
v
yes I was a bit confused by this
so after doing that should I use snapshot false like they are doing?
e
No
✅ 1
Oh
v
yep they are false
e
Weird. Let me remember why.
I don’t remember why. And the diff is very minor.
Seems like snapshot should be fine.
✅ 1
v
@Erik Osterman (Cloud Posse) can you suggest anything here please 🤷‍♂️ https://github.com/cloudposse/atmos/actions/runs/12892693482/job/35947771835?pr=941#step:11:57438
looks like the cause is my snapshot coming from ARM
a quick suggestion would be changing the regex
e
just try to add:
Copy code
expect:
  diff:
  - '👽 Atmos (\d+\.\d+\.\d+|test) on [a-z]+/[a-z0-9]+'
✅ 1
any line that matches the diff, will get skipped
Did that work for you?