can you review this <https://github.com/cloudposse...
# atmos-dev
h
e
@Andriy Knysh (Cloud Posse)
a
@Haitham i saw a similar error before, it happens when you give a relative path to
go-getter
and it can't find the file
using
go-getter
with files is very convoluted, it caused issues in the past
that's why in my latest PR https://github.com/cloudposse/atmos/pull/943/ i stopped trying to use
go-getter
for local file, and instead detect all absolute and relative paths and just read the file using plain
Go
. All other protocols are handled by
go-getter
h
I just need to know when run vendor should we handle relative paths from source "../../src"
I get the error I should handle it as local path not remote
a
what did you ask to review, the error itself or you need some guidance?
h
yes I need to know when vendor source "../../src" should we import from relative path
I fixed it
a
but you added that, correct? so we should test it
h
I will add test URI contain path traversal
👍 1
e
h
please review the PR also I improved the error handle and log for remote and local source