<https://github.com/cloudposse/atmos/pull/914> Let...
# atmos-dev
s
https://github.com/cloudposse/atmos/pull/914 Let us push this guys. It is growing a lot...And we already spent a lot of time on rebasing this thing
e
@Andriy Knysh (Cloud Posse) let’s get this merged next. It overhauls all the argument and flag handling in a consistent way. It touches a lot of files and is easily conflicted
It also adds tons of test cases on argument and flag handling, so we can reduce regressions
a
yes, releasing another one now, will do this one next
d
@Shubham Tholiya since this was merged, I'm having trouble getting the acceptance tests to pass locally. Is there a new requirement that I may be missing? In particular related to
tty: false
s
🤔 Which test is particularly failing? There should be nothing that fails at least from help tests perspective because that is the only command i touched pure stdout messages
d
I found the issue! It was a simple timeout when trying to vendor. I have a fix and will create a PR in a few
e
@Dan Miller (Cloud Posse) timeouts related to vendoring were fixed in https://github.com/cloudposse/atmos/pull/939
👀 1
I want to make sure the fix is congruent
The issue was multi-fold • GitHub token was not passed to step as env • GitHub token in go test was not passed in env to atmos as env
And GitHub token env is used when vendor sources starting from https://github.com/cloudposse/atmos/pull/912
So any thing related to vendoring not working due to tokens, is a bug, not a limitation.
Is there a hard coded timeout?