<@UB89GSWCF> this is ready for review <https://git...
# atmos-dev
e
@Andriy Knysh (Cloud Posse) this is ready for review https://github.com/cloudposse/atmos/pull/896
a
@Shubham Tholiya please address the comment
s
Done
Just posting this here again. Because i know tests failed for ubuntu and macos. They were for totally unrelated test and restarting fixed the issue. Hope this gets merged today 😅
e
Left some more comments
And one more about the location of the fixture
s
Did that
Let us push this.. resolved the conflicts again 😅 https://github.com/cloudposse/atmos/pull/896
👀 1
a
@Shubham Tholiya please address the comments
s
Done Just waiting for the build to succeed
merged 1
a
@Shubham Tholiya this version of the checker github.com/editorconfig-checker/editorconfig-checker/v3 v3.0.3 works (and it's merged to
main
now they released a new (minor) version github.com/editorconfig-checker/editorconfig-checker/v3 v3.1.2 and it broke the code in
cmd/validate_editorconfig.go
please open a new PR, update the the latest version, and fix the issues
s
sure
https://github.com/cloudposse/atmos/pull/955 This is a quick update followup @Andriy Knysh (Cloud Posse) 🙂
👀 1
a
@Shubham Tholiya please review the failing tests https://github.com/cloudposse/atmos/actions/runs/12853137760?pr=955
s
Done
@Andriy Knysh (Cloud Posse) this should be a good fast one 🙂
✅ 1
merged 1