<@U02BF49S8UR> something I missed in your PR. I do...
# atmos-dev
e
@Dan Miller (Cloud Posse) something I missed in your PR. I don't like the name of these test-cases:
complete
because it's neither complete, nor based on a convention. If it were based on a scenario or demo, I think it would make more sense.
So I think for now, we create a .yaml config for the test cases of each scenario or demo
d
that is everything that used to be just the 1 example
rather than breaking it up, I just called it "complete"
e
i know, but your next PR will introduce a new file, no?
Then the file called
complete
is not complete.
And complete has no meaning.
d
yeah each new PR creates a new example
what's a better name?
e
like I suggested, naming it after the scenario makes sense to me.
so we have a lot of tests that are for
complete
, but then the tests should actually be changing to that directory
in this case, the tests are changing to a different directory
d
what is the scenario though, if the scenario is all existing tests
it used to just be called
examples/test
e
CleanShot 2025-01-09 at 14.41.52.png
image.png,image.png
d
yes but what would you call a scenario that we have been using with all existing tests?
legacy sounds bad
e
I'm okay with calling the scernario complete. My point is that
test-cases/complete.yaml
tests things that are not in compelte
d
agree, but naming is hard
e
so if a test is testing relative-paths, I'm saying call the file
test-cases/relative-paths.yaml
if a test is testing scenarios/complete, I'm saying call the file
test-cases/complete.yaml
d
agree on that too, that's what I believe I did
e
no, because
test-cases/complete
is testing things that is not in `scenarios/complete`1
d
ohh
i see what you mean
okay
just need to break up the test-cases/complete into test-cases/complete and test-cases/demos
or would you rather having 1 per demo?
also probably should create one called
core
Copy code
/tests/test-cases
  core.yaml
  complete.yaml
  demos.yaml
  relative-paths.yaml
  metadata.yaml