<@UB89GSWCF> hotfix for Prod <https://github.com/...
# atmos-dev
v
@Andriy Knysh (Cloud Posse) hotfix for Prod https://github.com/cloudposse/atmos/pull/916
e
@Vinny looks like it's related to some other change
@Andriy Knysh (Cloud Posse) accidentally merged your previous PR
v
yep it's the pointers
a
i did not release anything, let's fix all of that in this PR
e
a
these tests are still failing
internal/exec/stack_processor_utils.go
@Vinny i suggest we reverse the commit from https://github.com/cloudposse/atmos/pull/907 so the
main
branch is clean
this PR broke a few things
and
internal/exec/stack_processor_utils.go
still failing
(the PR was prob not synched with the
main
branch for some time, and I forgot to check that)
v
which commit you want to revert or entire PR?
a
we can revert the entire PR or maybe you can fix it in https://github.com/cloudposse/atmos/pull/916 internal/exec/stack_processor_utils.go is failing
v
hold on a bit
let me understand the errors
a
i would revert the PR b/c it was prob old (not synched with
main
) and it broke at least 2 things (I fixed one)
Copy code
=== RUN   TestStackProcessor
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1053c7604]
i already fixed a similar error (and the fix was already in
main
)
lets wait CI on this and see
a
i also test PRs locally (you should do it too)
make testacc
✅ 1
v
good @Andriy Knysh (Cloud Posse)
will create another PR with updated main
thanks !
a
i merged the PR
🙌 1
yes, please open a new one instead of https://github.com/cloudposse/atmos/pull/907
✅ 1
v
ok
a
please make sure you add all the sections correctly in
atmos.yaml
in your new PR
✅ 1
v
yes this conflict from other change
I think the big mistake here was outdated PR