<@UB89GSWCF> looks like good now <https://github.c...
# atmos-dev
v
@Andriy Knysh (Cloud Posse) looks like good now https://github.com/cloudposse/atmos/pull/853
a
@Vinny this config in
atmos.yaml
Copy code
# Syntax highlighting configuration
  syntax:
    enabled: true
    theme: "dracula"      # or use custom colors from theme
    line_numbers: true
    wrap: false
looks like it's a separate sub-section under
settings
but it's not in
schema.go
it's eigher needs to be removed from
atmos.yaml
and the docs, or used in
schema.go
and in the code
e
this should be
settings.terminal.syntax
(Which it currently is)
v
I think we are good to remove this syntax
colorize should handle yaml
a
@Vinny please ping me here when you finish all the changes
e
Why remove? What does removing it solve
we don't need it there at all as we have custom colors
e
But themes is nice too :-)
v
yeah indeed its your guys decision at the end
e
But I don’t understand why we have both “syntax” and “syntax_highlighting”
v
will be only this syntax_highlighting we can rename it
e
Image from iOS.jpg,Image from iOS.jpg
Let’s combine
But yes, I prefer we keep support for themes
But document where the list of themes is found
v
so to summarize right now we have • Glamour with markdown with custom colors • Themes for yaml colorized • (chroma themes for Glamour also) This is not implemented now
I can do this chroma in the same glamour PR or we can create another feature to implement it, up to you @Erik Osterman (Cloud Posse)
e
Let’s do that in a new PR
But yes, let’s do that. Can you write a linear task and self assign
v
sounds good
@Andriy Knysh (Cloud Posse) good to check now please
merged 1