Hi everyone! could I please get some eyes on this:...
# contributing-to-starrocks
g
Hi everyone! could I please get some eyes on this: github.com/StarRocks/starrocks/pull/71749 it has been stalled since I addressed the comments in July. πŸ™‚ Thank you so much in advance!!
k
the code conflicts the current main branch, need a rebase
g
@Kevin Cai rebased it now! would love it if you/the team are able to take a look πŸ™‚
πŸ‘€ 1
hey @Kevin Cai anything else needed from my side? the PR has passed all checks except failed to provision an ECI instance for testing due to capacity issues from AWS.
looks like the pipeline was a success @Kevin Cai great πŸ™‚ let me know if there is anything more you need from me ! happy to help
@Kevin Cai it seems like you have approved the changes which is awesome! is the PR waiting on anything else before it can be merged ? πŸ™‚
@Kevin Cai I just saw that the related issue is closed here github.com/StarRocks/starrocks/issues/71547#… do you mind reopening? I am also wondering if anything else is holding up the PR I see it needs another approval on top of yours. Can I do anything to follow up with anyone else to help get this merged πŸ™‚
k
The PR conflicts with the main branch, needs a rebase and resolve the conflict before it can be merged.
g
hi @Kevin Cai thanks for the response I can see that. I have rebased it again, can you please approve again, keen to get it merged this time πŸ™‚ I think we need another approver from your side. Thanks for reopening the related issue!
thanks a lot for helping to get this merged!!