Hi everyone :wave: This is my first contribution ...
# contributing-to-starrocks
a
Hi everyone πŸ‘‹ This is my first contribution to StarRocks β€” excited to be here! The bug While testing ADLS2 cluster snapshot disaster recovery, I hit an issue where FE startup aborts during the restore. The recovery tooling injects
AZURE_PATH_KEY
into the storage volume params to reconstruct the volume config, but that key isn't registered in
CloudConfigurationConstants.PARAM_NAMES
. So
StorageVolumeMgr.validateParams()
rejects it with
DdlException: Invalid properties azure_path_key
, and the FE never finishes coming up β€” which effectively makes the cluster unrecoverable from snapshot on ADLS2. Stack trace:
Copy code
ERROR StarRocksFE start failed
  com.starrocks.common.DdlException: Invalid properties azure_path_key
    at StorageVolumeMgr.validateParams(StorageVolumeMgr.java:386)
    at StorageVolumeMgr.replaceStorageVolume(StorageVolumeMgr.java:224)
    at RestoreClusterSnapshotMgr.updateStorageVolumes(RestoreClusterSnapshotMgr.java:254)
    at RestoreClusterSnapshotMgr.finishRestoring(RestoreClusterSnapshotMgr.java:93)
    at StarRocksFE.start(StarRocksFE.java:206)
The fix Skip validation of
AZURE_PATH_KEY
in
StorageVolumeMgr.validateParams()
only when
RESTORE_CLUSTER_SNAPSHOT=true
is set in the environment. The guard is scoped strictly to DR β€” normal-path validation is untouched and unknown keys still throw as expected outside of restore mode. Also added a commented ADLS2 example block to
conf/cluster_snapshot.yaml
alongside the existing S3 and HDFS examples. Could anyone review the pull request? Since this is my first PR here, I'd really appreciate any feedback β€” on the approach, code style, test coverage, or anything I might have missed about the project's conventions. Happy to iterate on whatever needs changing. Pull Request: https://github.com/StarRocks/starrocks/pull/73509
πŸ‘ 1
loveit rocky 1