hey! I am just looking for some feedback/review on...
# contributing-to-starrocks
g
hey! I am just looking for some feedback/review on this PR I put together to support nested JWT claims. This is essential to support AWS Outbound Identity Federation and any other IDPs that use nested claims. https://github.com/StarRocks/starrocks/pull/71749
hi team! just bumping this here. It is my first time contributing as well, looking to fix an auth feature gap in JWT parsing ๐Ÿ™‚ thanks so much for your time
๐Ÿ‘ 1
k
Hi Gus, Thanks for your contribution. The maintainers reviewed your PR today but there were some issues, please check the test result and feel free to leave a comment if you have any questions.
g
Hi Kate! the test result seems to be an ECI instance timeout. Otherwise everything seemed to pass. https://github.com/StarRocks/starrocks/actions/runs/24458241215/job/75943680773?pr=71749
Looks like it timed out trying to create an instance to build the FE
cc @Kate Shao-Community Manager ๐Ÿ™‚ just in case you don't get thread notifications!
github.com/StarRocks/starrocks/pull/71749 Hi @Kate Shao-Community Manager I have updated and addressed the comments from the maintainers on this PR but haven't heard anything back. Would appreciate it if you were able to follow up with them ๐Ÿ™‚