Hey guys, I have upgraded to starrocks-operator 1....
# questions-and-troubleshooting
g
Hey guys, I have upgraded to starrocks-operator 1.11.4 from 1.11.1, and I had an issue with the CRD update: helm doesn't support it (!!) And in 1.11.2 you instroduced a new field in the starrockscluster CRD: podManagementPolicy. Now all starrocks-cluster charts deploy it. This is a typical issue with CRDs and helm: helm won't reapply them, and you should do it manually. To solve the issue, I applied it like this:
k apply -f charts/operator/crds/starrocks.com_starrocksclusters.yaml --server-side --force-conflicts
My problem is that this is not clear in the versioning of the chart: in a patch version, you introduced a breaking change in the API of the CRD, without telling about it in the changelog. I see a few ways of solving this: • first, talk about it in the CHANGELOG or the README. This is what prometheus is doing for their CRDS: https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/UPGRADE.md • you could also make major versions of the chart when the CRD evolves • there's also a way to upgrade automatically via a job that has proper RBACs, like prom are doing, but this doesn't prevent you from adopting a proper semver for the operator chart.
👀 1
k
@Ray Yan thought the new field is optional and by default helm chart should not generate the optional field for the cr. need double check on this.
👀 1
r
This is indeed a problem, and I think we’ve introduced a breaking change that will cause failures when users deploy clusters with Helm.
k
can we update the release notes, highlight this break change at least?
r
Sure, I will update it now
g
Thank you a lot !