Anything I can do to accelerate the review of some...
# contributing-to-starrocks
k
Anything I can do to accelerate the review of some of my 4.1 targeted PRs for bug fixes? Some the IVM issues seem pretty critical and that is a huge feature for 4.1.
k
can you list the issues/prs?
k
4.1 Issues: https://github.com/StarRocks/starrocks/issues/69558 https://github.com/StarRocks/starrocks/issues/69502 https://github.com/StarRocks/starrocks/issues/69493 Not a 4.1 Issue but without bucket transform support it is very tough to scale StarRocks to ingest large iceberg datalake tables into async mvs: https://github.com/StarRocks/starrocks/issues/69350 Not 4.1 specific but a pretty significant bug: https://github.com/StarRocks/starrocks/issues/68965 PRs I have open to fix some of the 4.1 issues above and the struct issue: https://github.com/StarRocks/starrocks/pull/69531 https://github.com/StarRocks/starrocks/pull/69496 https://github.com/StarRocks/starrocks/pull/68967
Issue 69558 above I don't have a fix for. This one also significantly impacts the usefulness of the IVM refresh because it seems to be preventing the backfill of historical data into a new async MV for very large tables. Basically if you have a massive iceberg table and set the refresh mode to auto it seems to prematurely switch off PCT. This causes huge gaps in historical data as it does not attempt to ingest all those existing partitions and seems to just switch to incremental. the only IVM refresh views I have been able to get working on large iceberg tables in 4.1 are views that are essentially "replace views" that only have latest state data and not historical data. For that IVM works great with my fixes above. We've been running a branch off 4.1 using my fixes above built from source in order to test it.
k
wow~, that's a lot, may need some time to consume all these by the maintainers. Thanks a lot for the contribution!
j
@Kevin Cai will https://github.com/StarRocks/starrocks/pull/69825 (replacing @Kyle Goodales https://github.com/StarRocks/starrocks/pull/69496) make it as part of 4.1.0 release?
k
ok. will pull someone to take a look.
j
Also there is as similar ask in the main channel https://starrocks.slack.com/archives/C02FAD0JSSD/p1772714226850369
And Thank you.
🤝 2
👀 1
b
Thanks, I see it is merged